Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1226486 ] Fixes #1224178
|
From: SourceForge.net <no...@so...> - 2005-07-05 14:28:24
|
Patches item #1226486, was opened at 2005-06-23 15:23 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Richard Laager (rlaager) Summary: Fixes #1224178 Initial Comment: Fixes #1224178. Only tested with IRC. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-07-05 10:28 Message: Logged In: YES user_id=644705 Good catch @ leak - update attached. Whether the other protocols send back the new topic to the node that requests the change was my worry as well; imo any "sane" protocol would do it, but I guess we'll see. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 01:50 Message: Logged In: YES user_id=156487 This leaks memory if you hit this if block: if(current_topic && !g_utf8_collate(new_topic, current_topic)) It needs to g_free(new_topic); inside that block. This works for IRC because the server sends back the new topic, which causes Gaim to update the text box. I'm not sure how this works for Jabber, SILC, and Zephyr, which are the other protocols which define set_chat_topic. I think you're taking the correct approach here. If the other protocols' servers don't send a topic update back to the client on success, they can fake it. I'm going to try to find out what the situation is with those protocols and what the developers who maintain the relevant prpls have to say about this. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-23 15:24 Message: Logged In: YES user_id=644705 (Also applies to oldstatus.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 |
