[Gaim-patches] [ gaim-Patches-1231528 ] Oscar crash fix (?) (HEAD)

[SourceForge.net <no...@so...>]

Patches item #1231528, was opened at 2005-07-02 22:09
Message generated for change (Comment added) made by sadrul
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Sadrul H C (sadrul)
Assigned to: Mark Doliner (thekingant)
Summary: Oscar crash fix (?) (HEAD)

Initial Comment:
Hello.

Gaim seems to be crashing when I enable an AIM account,
and couple of seconds later, while it's still
connecting, disable it. I have attached the backtrace
and the patch which seems to have fixed the problem.

-- Adil

----------------------------------------------------------------------

>Comment By: Sadrul H C (sadrul)
Date: 2005-07-03 22:36

Message:
Logged In: YES 
user_id=1132702

The crash is reproduceable with a plugin, but not without
it. The problem that's occuring is this:

Gaim in HEAD uses _set_status functions to
connect/disconnect an account. The plugin used the old-style
_connect and _disconnect functions for that purpose. These
functions work just fine with protocols like msn/irc without
any problem because they don't [yet] consider the `status'.
Yahoo does consider it, but it ignores GAIM_STATUS_OFFLINE
status. Among the ones I have looked into
(yahoo,msn,irc,oscar) oscar is the only one to check for
that, and hence it does not go upto the part where od->sess
gets set.

I would suggest the _connect/_disconnect functions be made
unavailable to the plugins, since those are likely to be
causing further similar problems.

-- Adil

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2005-07-03 16:49

Message:
Logged In: YES 
user_id=20979

Is this reproduceable for you?  I could not reproduce it,
and I don't really understand how this crash should
happen... od->sess should really never be null.  It should
be in oscar_login at the same time od is created, and never
freed.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-07-03 11:04

Message:
Logged In: YES 
user_id=156487

This looks pretty simple and safe, but I don't know for sure so I'm 
assigning it to Mark. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235