[Gaim-patches] [ gaim-Patches-1231506 ] Implementing gaim_accounts_get_all_active (HEAD)

[SourceForge.net <no...@so...>]

Patches item #1231506, was opened at 2005-07-02 09:54
Message generated for change (Comment added) made by rlaager
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Sadrul H C (sadrul)
Assigned to: Nobody/Anonymous (nobody)
Summary: Implementing gaim_accounts_get_all_active (HEAD)

Initial Comment:
Hello.

gaim_accounts_get_all_active functions is declared in
src/account.h which should return a list of active
(enabled) accounts, but it is not implemented anywhere.
This patch implements the function.

-- Adil

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2005-07-03 01:12

Message:
Logged In: YES 
user_id=156487

All other uses of that function (the ones which use 
GAIM_GTK_UI) are in files name gtkBLAH.c, so they're part of 
the GTK+ UI. 
 
When adding #includes to a file where the #includes are sorted 
alphabetically within blocks, please add the new #include to the 
block in alphabetical order. 
 
Thanks for the patch. 
 

----------------------------------------------------------------------

Comment By: Sadrul H C (sadrul)
Date: 2005-07-03 00:54

Message:
Logged In: YES 
user_id=1132702

I am currently writing a plugin to do the status-works. It
requires this function. Right now, I can include this
function in my plugin, but I realized the function is
planned to be included in the core anyway (since it's there
in account.h).

[The plugin I am working on:
http://sourceforge.net/projects/geam]

-- Adil

----------------------------------------------------------------------

Comment By: Sadrul H C (sadrul)
Date: 2005-07-03 00:38

Message:
Logged In: YES 
user_id=1132702

GAIM_GTK_UI is the GTK+ UI code here? I have replaced it
with gaim_core_get_ui() function (which is also used in
src/status.c). This probably honours the core/ui split?

gaim_account_get_enabled seems always to be using
GAIM_GTK_UI as the second parameter (except for that one
instance) which seems rather confusing right now, but that's
probably another matter.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-07-03 00:14

Message:
Logged In: YES 
user_id=156487

This patch is using GTK+ UI code in a core file. This breaks the 
core/ui split. I don't know what the plan is for that function. Unless 
you have a need for it, let the developer(s) working on status get 
to it. If you do have a need for it, talk to someone that knows what 
the status API is supposed to be like before implementing it. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235