[Gaim-patches] [ gaim-Patches-1218914 ] Backporting buddy-icon-cached-signal and buddy-icon-extn

[SourceForge.net <no...@so...>]

Patches item #1218914, was opened at 2005-06-11 16:04
Message generated for change (Comment added) made by rlaager
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218914&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Sadrul H C (sadrul)
Assigned to: Nobody/Anonymous (nobody)
Summary: Backporting buddy-icon-cached-signal and buddy-icon-extn

Initial Comment:
backporting two seperate patches ([ 1211718 ] "Set
Extension for Saving Buddy Icons" and [ 1197984 ] "Add
a Buddy Icon Cached Signal" : both by rlaager] for
oldstatus (a combined patch).

-- Adil

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-25 18:44

Message:
Logged In: YES 
user_id=156487

I've taken this patch and cleaned it up. It should be in a directly 
committable state as 1227578. 

----------------------------------------------------------------------

Comment By: Sadrul H C (sadrul)
Date: 2005-06-19 09:02

Message:
Logged In: YES 
user_id=1132702

Hello.

1. updated value.h accordingly
2. I don't think I tampered with any comments. I checked
with HEAD, and it does seem the comments are in order.
3. Do I update the Changelog accordingly and submit a patch
for that, or will that be done if/when this patch get's
accepted by some dev?

-- Adil

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-11 23:58

Message:
Logged In: YES 
user_id=156487

As it stood, the plugin didn't even use the buddy icon type stuff 
yet. I just fixed that. However, for oldstatus, I could do the type 
stuff in the plugin. 
 
To the as-yet-unassigned developer: 
If it makes it easier, only the signal needs to be backported. Let 
me know what you'd like to do. 

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-11 16:53

Message:
Logged In: YES 
user_id=156487

There are a couple things that need changing on this patch: 
 
1. In value.h, this should not be adding a value to the middle of 
the enum. The end is fine. The reason for this is that it breaks 
binary compatibility (which is not allowed except for major 
releases). 
 
2. The comment about GDK should be changed to match what it 
says in HEAD. This isn't a big deal, but it makes it consistent. 
 
3. This incorporates the buddy icon saving change. (A real 
extension is set instead of .icon.) This was ChangeLog'ed for 
2.0.0. If this backport is to be accepted, that needs to be 
ChangeLog'ed in oldstatus and removed in HEAD. 
 
Be aware that this would force an increase in the minor version. 
 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218914&group_id=235