From: SourceForge.net <no...@so...> - 2005-06-25 21:58:06
|
Patches item #1224610, was opened at 2005-06-21 00:49 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Buddy Icons Not Being Removed Initial Comment: Buddy icon cache files are removed when replacing icons but not when unsetting the icon. This patch corrects that. I think this fixes the only case where buddy icon cache files are not being deleted when they should be. I'd like to hear if anyone is seeing otherwise after this patch is applied. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-25 16:58 Message: Logged In: YES user_id=156487 Here are patches for HEAD and oldstatus. The patch for oldstatus increases the minor version number. Mark, We had talked about how I was going to clean up sadrul's backport of two of my patches. You said you'd accept them as long as they didn't break anything in oldstatus. This would increase the minor version of oldstatus anyway, so that's why this patch to oldstatus adds a new function. I'll clean up the backport patch later today. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-22 18:08 Message: Logged In: YES user_id=156487 I thought about adding a function to buddylist.c to delete the icon file. With the current architecture, that spot in blist.c is the only non-buddyicon.c code to delete a buddy icon cache file. I wasn't sure that it justified adding another public function. Also, there's the issue of increasing the minor version on oldstatus. It sounds like you'd have no objections to a new function in buddylist.c, so I'll rework the patch to add one. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 17:27 Message: Logged In: YES user_id=20979 It looks like gaim_buddy_icon_cache() in src/buddylist.c is responsible for writing the buddy icon file? Would it make more sense if blist.c called a buddylist.c function to delete the icon file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 |