[Gaim-patches] [ gaim-Patches-1224386 ] Global pref for keepalive ping

[SourceForge.net <no...@so...>]

Patches item #1224386, was opened at 2005-06-20 16:21
Message generated for change (Comment added) made by thekingant
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Rejected
Priority: 5
Submitted By: Levi Bard (tak_tak)
Assigned to: Ethan Blanton (eblanton)
Summary: Global pref for keepalive ping

Initial Comment:
Patch to ping IRC servers at arbitrary intervals in
order to prevent connections from dropping.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2005-06-23 11:50

Message:
Logged In: YES 
user_id=20979

I think timing out connections within 30 seconds constitutes
a broken network, and I don't think the addition of this
preference is really justified.  If you want opinions from
more people, feel free to raise the issue on gaim-devel.

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-23 11:38

Message:
Logged In: YES 
user_id=644705

OK, this run is as a global network pref, and uses
gc->keepalive.  On a decent network, the default *should* be
fine, but there are some networks bad enough where this is
not the case.

Screenshot at http://bard.sytes.net/global_ping_again.jpg

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-22 13:40

Message:
Logged In: YES 
user_id=199625

I don't actually mean to make it a preference, but if you
*did*, it would be a single option in Network, not multiple
options for each protocol.

Regardless, there is no NAT device that can't keep a
connection open for at least a minute. Leaving it
unconfigurable should be fine.

-s.

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-22 13:37

Message:
Logged In: YES 
user_id=644705

The point of this is that the buddy list keepalive isn't
often enough in some circumstances.  (Yes, the NAT is
misconfigured, but it's not my NAT and I can't fix it!)  I
could add a global keepalive interval in GaimConnection, and
let prpl maintainers use it or not at their whim, if that
would be preferable.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2005-06-22 13:33

Message:
Logged In: YES 
user_id=20979

Er, well it seems like you could add a preference to the
preferences window...

But I'm not sure that's really needed.  After what Sean
wrote, it sounds like maybe you could just implement
gc->keepalive for IRC and make it so that it only sends the
keepalive packet if your buddy list is empty.

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-22 09:54

Message:
Logged In: YES 
user_id=644705

If I add this option globally, it will require another field
on the account options for EVERY builtin prpl.  Will that
really be acceptable?

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-21 17:41

Message:
Logged In: YES 
user_id=199625

It took me a while to figure out why I was getting booted
from Freenode, and then I discovered it was because my NAT
wasn't keeping the connection open. Adding Nickserv to my
buddy list *did* serve as a decent workaround.

If that was the problem, you would be constantly kicked off
other protocols such as AIM, as well, which would likewise
need modification. gc->keepalive is certainly the correct
place to send keepalive packets.

-s.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2005-06-21 17:35

Message:
Logged In: YES 
user_id=20979

I agree with Sean and Luke.  I'm going to close this for
now.  If you take another stab at it, you may want to look
into using gc->keepalive

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-06-21 10:16

Message:
Logged In: YES 
user_id=28833

Sean is right.  one minute *should* be enough.  your NAT is
badly configured ;-)

that being said, I really have no basis on which to comment
on this patch from a technical standpoint. 

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-21 09:17

Message:
Logged In: YES 
user_id=644705

Once a minute is NOT enough, as evidenced by the fact that
the workaround of putting someone on your buddy list isn't
enough in several instances.  It's on a per-irc-server basis
now, because servers are *supposed* to ping their clients
often enough to keep them alive; however, some (freenode) don't.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-20 16:56

Message:
Logged In: YES 
user_id=199625

This function has no need to be configurable; once a minute
should be plenty often enough to keep a NAT tunnel open, and
if not the feature should be globally configurable so that
AIM server pings happen more frequently as well.

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-20 16:46

Message:
Logged In: YES 
user_id=644705

The existing ison functionality isn't at adjustable
intervals, and I thought it would be better to allow
increasing the frequency of a single ping rather than
whatever arbitrary number of buddies the user happens to
have for each connection.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-20 16:26

Message:
Logged In: YES 
user_id=199625

This is great, but implemented wrong.

Find the existing IRC keepalive function, currently used
solely to poll the buddy list with a RNG command, and if
there is no buddy list, send a PNG command instead.

-s.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235