Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1223465 ] MSN Buddy Icon File Existence Check
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:07:35
|
Patches item #1223465, was opened at 2005-06-19 00:47 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: MSN Buddy Icon File Existence Check Initial Comment: The MSN prpl considers the existence of a buddy_icon setting for a buddy in blist.xml to mean that a buddy icon exists. If the cache file has been deleted, this causes Gaim to fail to retrieve a new buddy icon. Why would an icon be missing from the cache folder? For me, it was because I work with multiple running copies of Gaim while developing. They step on each other's toes. For others, this situation could happen if the cache folder was purged by the user (or one of his scripts) or if the user is synchronizing ~/.gaim but excludes the icons folder (e.g. for size reasons). I realize these scenarios aren't very common, but this is a one-line patch that shouldn't cause any problems. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-22 18:07 Message: Logged In: YES user_id=156487 I see you changed it. I was trying to avoid having too many conditions on one line, but this looks fine. In oldstatus, you'd need to use buddy->name. It's not really a big deal if this goes into oldstatus or not. Users should rarely hit this. On the other hand, it'll only take a second to add this to oldstatus. You're the one with commit access, so it's your call. ;-) ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 17:59 Message: Logged In: YES user_id=20979 I changed this around a tad bit, but it should have the same effect. Thanks Oh, and I only applied it to head. gaim_buddy_get_name doesn't exist in oldstatus. But it seems like this is pretty minor, so that shouldn't matter too much? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 |
