[Gaim-patches] [ gaim-Patches-1224386 ] IRC keepalive ping

[SourceForge.net <no...@so...>]

Patches item #1224386, was opened at 2005-06-20 16:21
Message generated for change (Comment added) made by tak_tak
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Rejected
Priority: 5
Submitted By: Levi Bard (tak_tak)
Assigned to: Ethan Blanton (eblanton)
Summary: IRC keepalive ping

Initial Comment:
Patch to ping IRC servers at arbitrary intervals in
order to prevent connections from dropping.

----------------------------------------------------------------------

>Comment By: Levi Bard (tak_tak)
Date: 2005-06-22 09:54

Message:
Logged In: YES 
user_id=644705

If I add this option globally, it will require another field
on the account options for EVERY builtin prpl.  Will that
really be acceptable?

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-21 17:41

Message:
Logged In: YES 
user_id=199625

It took me a while to figure out why I was getting booted
from Freenode, and then I discovered it was because my NAT
wasn't keeping the connection open. Adding Nickserv to my
buddy list *did* serve as a decent workaround.

If that was the problem, you would be constantly kicked off
other protocols such as AIM, as well, which would likewise
need modification. gc->keepalive is certainly the correct
place to send keepalive packets.

-s.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2005-06-21 17:35

Message:
Logged In: YES 
user_id=20979

I agree with Sean and Luke.  I'm going to close this for
now.  If you take another stab at it, you may want to look
into using gc->keepalive

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-06-21 10:16

Message:
Logged In: YES 
user_id=28833

Sean is right.  one minute *should* be enough.  your NAT is
badly configured ;-)

that being said, I really have no basis on which to comment
on this patch from a technical standpoint. 

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-21 09:17

Message:
Logged In: YES 
user_id=644705

Once a minute is NOT enough, as evidenced by the fact that
the workaround of putting someone on your buddy list isn't
enough in several instances.  It's on a per-irc-server basis
now, because servers are *supposed* to ping their clients
often enough to keep them alive; however, some (freenode) don't.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-20 16:56

Message:
Logged In: YES 
user_id=199625

This function has no need to be configurable; once a minute
should be plenty often enough to keep a NAT tunnel open, and
if not the feature should be globally configurable so that
AIM server pings happen more frequently as well.

----------------------------------------------------------------------

Comment By: Levi Bard (tak_tak)
Date: 2005-06-20 16:46

Message:
Logged In: YES 
user_id=644705

The existing ison functionality isn't at adjustable
intervals, and I thought it would be better to allow
increasing the frequency of a single ping rather than
whatever arbitrary number of buddies the user happens to
have for each connection.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-20 16:26

Message:
Logged In: YES 
user_id=199625

This is great, but implemented wrong.

Find the existing IRC keepalive function, currently used
solely to poll the buddy list with a RNG command, and if
there is no buddy list, send a PNG command instead.

-s.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235