[Gaim-patches] [ gaim-Patches-1222657 ] better yahoo buzz

[SourceForge.net <no...@so...>]

Patches item #1222657, was opened at 2005-06-17 14:26
Message generated for change (Comment added) made by gabbath
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222657&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gabbath (gabbath)
Assigned to: Nobody/Anonymous (nobody)
Summary: better yahoo buzz

Initial Comment:
sorry, cvs didn't work, following the directions on
your site so i diffed against regular gaim 1.3.1
...anyway, don't think it actually matters that much,
it's not a core thing, just added a few lines here and
there (i'm just a beginner)

Changes:

src/sound.h -> added GAIM_SOUND_BUZZ_YAHOO
src/protocols/yahoo/yahoo.c -> made it play buzz sound
when "<ding>" message is received (just added a
gaim_sound_play_event line)
src/gtkprefs.c -> added a small comment about the buzz
sound bypassing sound options (just thought the user
should know... might have been better to use a
tooltip...) - thought it should bypass as it's supposed
to get your attention and shouldn't be muted, but you
can always uncheck it from the sounds list if you want to
src/gtksound.c -> added "Someone buzzes you (Yahoo
only)" to sounds in preferences; you can use the
default sound or you can use a sound of your choice...
it's integrated just like the other sounds, it just
bypasses the sound options in prefs
sounds/makefile.in and sounds/makefile.am (also added
sounds/buzz.wav) -> embeds the buzz sound within gaim
and installs it along with the other default sounds
plugins/buzz.c -> this is a patch for the buzz plugin
by avinash prasad which i consider to be the best for
gaim; it can send buzz to someone via Ctrl+G shortcut
and also displays "BUZZ!!!" in conversation; i also
added a gaim_sound_play_event line to it and so it now
plays the sound (specified in prefs) when you buzz
someone (not very useful, but still...)
you can find the original buzz plugin here:
http://www.cse.iitd.ernet.in/~csd00379/buzz.c

Description:

well what you get from all this mess is that now you
can send and receive the buzz if you're on a yahoo
account. you can send it with sound via ctrl+g (through
the buzz plugin by avinash prasad) or without sound via
/buzz (through gaim main). when you receive it you also
receive it with sound. the sound is universal, you can
either enable or disable it from sound preferences. i
included a default sound (sounds/buzz.wav, not the buzz
sound from yahoo but rather a higher pitched version of
arrive.wav - didn't want to infringe any copyrights)
but you can also select another file to play, from your
disk, even the doorbell.wav from the yahoo messenger
directory. The behaviour is practically identical to
yahoo messenger and... well... i guess that's all that
matters in the end for a yahoo user switching to gaim :)
couldn't help myself from changing "Buzz!!" to a bolded
"BUZZ!!!" :)

----------------------------------------------------------------------

>Comment By: Gabbath (gabbath)
Date: 2005-06-19 09:04

Message:
Logged In: YES 
user_id=1298580

>First off, I don't like this idea of a sound bypassing...

Well you can just disable the sound in the first place, but
I agree with you that some people might find this
unacceptable, and if not then just plain unesthetic. So how
about this then: treat it like the other sounds by default,
but add a third sound option whether or not to have buzz
bypass the sound options. No hurt in that :)

>Second, if you're adding a sound, it should be something...

I designed it this way because I only use Yahoo. Silly me.
Of course this thing should be extended to all protocols
that have similar features. I'm just not familiar with the
others. But buzz is a first step.
Anyway, my overall point was that buzzes/nudges/whatever are
first of all alerts, they're meant to notify you that
someone wants to talk to you, that there's an emergency or
something. So they need to be accompanied by sounds,
otherwise they're useless. And if I don't want sounds when
I'm away/idle (I don't want to be bothered anytime a buddy
signs on or off), I'd most certainly like to know if someone
has something urgent to tell me, hence the bypassing idea.
Oh, and if they're meant to be universal, they should be
called something like buddy alerts. And also a universal key
combination for alerting buddies.

----------------------------------------------------------------------

Comment By: Bleeter Yaluser (bleeter)
Date: 2005-06-19 08:02

Message:
Logged In: YES 
user_id=407708

I'm preparing a generic gaim core buzz, which will replace the current yahoo buzz. Feel free to beat me to finalisation :-)

Beyond that, I agree with rlaager's comments.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-19 04:29

Message:
Logged In: YES 
user_id=156487

First off, I don't like this idea of a sound bypassing the muting 
options. That's totally unacceptable. *I* control which sounds play 
on my computer, not another user sending me a buzz. 
 
Second, if you're adding a sound, it should be something along 
the lines of GAIM_SOUND_BELL because other protocols have 
similar features. For example, MSN has nudges. These will need 
to be treated the same by Gaim. Therefore, you shouldn't make 
this protocol specific (which is unacceptable for anything in the 
core, really). 
 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222657&group_id=235