|
From: SourceForge.net <no...@so...> - 2005-06-18 08:49:10
|
Patches item #1222664, was opened at 2005-06-17 14:34 Message generated for change (Comment added) made by gabbath You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222664&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Open Resolution: None Priority: 5 Submitted By: Gabbath (gabbath) Assigned to: Etan Reisner (deryni9) Summary: new signal: buddy-changed-status Initial Comment: i'm really sorry, i couldn't diff against the cvs because i'm probably doing something wrong. i followed the directions for downloading it but from the autogen.sh part it won't work... i'll try again later maybe. anyway, this isn't much, it's a really simple signal, but i find it very useful. also, it can probably be adapted quite easily for the cvs, as it just adds one or two lines of code :)) Changes: src/blist.c -> add "buddy-changed-status" plugins/signals-test.c -> test "buddy-changed-status" Description: the "buddy-changed-status" signal takes place whenever a specified buddy updates his/her status, status text or idle time. i found it very useful for a plugin that i made which shows the buddy's current status and idle time right in the IM window... and it might have other uses too. anyway, "buddy-away" and "buddy-back" aren't enough for this as yahoo (for instance) allows status messages even when you're not away, so instead of refreshing automatically every 30secs, i preferred to add this useful signal (for idle update i suppose one can use "buddy-idle-updated", but i thought it should actually engulf - as its name suggests - all the stuff related to a buddy's status). it's a bit weird that it gets emitted several times when a status changes, not just once, but i suppose it's because when a buddy changes his/her status, it goes from away to back and then away again or something. ---------------------------------------------------------------------- >Comment By: Gabbath (gabbath) Date: 2005-06-18 08:49 Message: Logged In: YES user_id=1298580 >It would seem that this patch is basically just for catching >when a buddy switches from one away state to another away >state, yes? well, not exactly, some protocols (like yahoo) can have states without actually being away, like the song they're playing in, say, winamp. and they still appear available. now buddy-away, buddy-back etc don't actually catch these signals as the contact is never really away... none of the signals do. that's why i defined it. oh, and... i have to correct something, it doesn't take place when buddy-idle-updated (my bad, sorry). perhaps i should not have it emit when the buddy goes idle and back... that was just for the sake of completenes, so you can ignore the changes made to gaim_blist_update_buddy_idle ---------------------------------------------------------------------- Comment By: Etan Reisner (deryni9) Date: 2005-06-17 22:30 Message: Logged In: YES user_id=516184 It would seem that this patch is basically just for catching when a buddy switches from one away state to another away state, yes? If that's the case is there a reason you decided to have it duplicate buddy-away, buddy-back, buddy-idle, and buddy-idle-updated rather than just adding a buddy-away-updated? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222664&group_id=235 |