|
From: SourceForge.net <no...@so...> - 2005-06-14 00:45:53
|
Patches item #1206146, was opened at 2005-05-21 09:37 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1206146&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 3 Submitted By: Ted Percival (midg3t) Assigned to: Mark Doliner (thekingant) Summary: Fix smooth scrolling assertions Initial Comment: Rewrite of GtkIMHtml's smooth scrolling algorithm in scroll_cb(). Fixes GLib timer assertion being triggered. A rewrite might be considered overkill. I rewrote the function before I figured out a decent way to fix the initial code... and I think that if nothing else, the new implementation is a bit more readable. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-13 20:45 Message: Logged In: YES user_id=20979 Looks good, thanks ---------------------------------------------------------------------- Comment By: Ted Percival (midg3t) Date: 2005-05-27 03:37 Message: Logged In: YES user_id=1011928 Good point. Amended patch attached. Also added a little bit more commenting. Patch is against current HEAD CVS. ---------------------------------------------------------------------- Comment By: Daniel Atallah (datallah) Date: 2005-05-25 11:04 Message: Logged In: YES user_id=325843 g_assert() shouldn't be used in this situation. If the scrolling is messed up, we don't need to be terminating the whole program. ---------------------------------------------------------------------- Comment By: Ted Percival (midg3t) Date: 2005-05-23 08:07 Message: Logged In: YES user_id=1011928 I should also point out that this is a patch against CVS. Please don't just say "bah, we don't need rewrites" -- I spent a considerable amount of time on this patch and [obviously] consider it worthy of inclusion. Assigning to marv on the recommendation of grim on IRC. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1206146&group_id=235 |