[Gaim-patches] [ gaim-Patches-1217334 ] Buddy Tag Escaping

[SourceForge.net <no...@so...>]

Patches item #1217334, was opened at 2005-06-08 21:03
Message generated for change (Comment added) made by datallah
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217334&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Richard Laager (rlaager)
Assigned to: Mark Doliner (thekingant)
Summary: Buddy Tag Escaping

Initial Comment:
(20:37:51) rlaager: I have a reproducible bug with the buddy 
tags. If the name includes a single quote, the colon before 
the seconds and everything onward is underlined. 
Thoughts on where I should start debugging? 
 
(20:41:58) Daniel Atallah (datallah): rlaager: i bet it is 
because of the escaped html entity 
 
(20:42:19) rlaager: datallah: Seems to be the case. Same 
thing happens with " 
 
(20:51:33) rlaager: datallah: Does the tag offset need to be 
changed in direction or another? 
 
(20:52:02) rlaager: Probably by something like 
strlen(who_escaped) - strlen(who) ?? 
 
(20:52:07) Daniel Atallah (datallah): rlaager: i'm guessing 
the strlen() needs to be replaced with something more 
intelligent 
 

----------------------------------------------------------------------

>Comment By: Daniel Atallah (datallah)
Date: 2005-06-09 00:18

Message:
Logged In: YES 
user_id=325843

Thanks.  I committed something based on this.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-08 22:24

Message:
Logged In: YES 
user_id=156487

Posting a new patch to handle the who == NULL case. This will 
save you some time. 

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-08 21:26

Message:
Logged In: YES 
user_id=156487

Whomever commits this should probably make that: 
 
strlen(who_escaped) - who ? strlen(who) : 0; 
 
This covers the case who == NULL. I'm not sure if that ever 
happens, but the code above the changed line seems to account 
for that case. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217334&group_id=235