|
From: SourceForge.net <no...@so...> - 2005-05-15 15:36:36
|
Patches item #1167921, was opened at 2005-03-21 22:06 Message generated for change (Comment added) made by killgunner You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1167921&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Joao Luís Marques Pinto (jpinto) Assigned to: Ethan Blanton (eblanton) Summary: IRC protocol - irc services alias Initial Comment: This patch adds the command /nickserv, /chanserv, /memoserv, /operserv, it is safer than the /msg option because more modern ircds will ensure that the message is routed to a service and not to a "fake" client. ---------------------------------------------------------------------- Comment By: Kaygee (killgunner) Date: 2005-05-15 15:36 Message: Logged In: YES user_id=1279062 *cough* /quote ---------------------------------------------------------------------- Comment By: Ethan Blanton (eblanton) Date: 2005-04-18 01:39 Message: Logged In: YES user_id=298616 Hmm, I thought I had commented on this bug already, but I see that I haven't. For one, I haven't decided if I would rather see these commands implemented in a plugin rather than the protocol itself (as they are quite nonstandard), or in the protocol since they have become relatively common. For another, rlaager's example leaks memory ... g_ascii_strup allocates memory. Ethan ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-18 01:15 Message: Logged In: YES user_id=156487 In cmds.c, why aren't you doing the following instead of the if...else if block? buf = irc_format(irc, "v:", g_ascii_strup(cmd, -1), args[0]); That function won't ever get called with a cmd that doesn't match one of the if blocks you have. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1167921&group_id=235 |