[Gaim-patches] [ gaim-Patches-1192785 ] oldstatus Fix for the message queue

[SourceForge.net <no...@so...>]

Patches item #1192785, was opened at 2005-04-29 19:24
Message generated for change (Comment added) made by frenchfrog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1192785&group_id=235

Category: newfeature
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: François Gagné (frenchfrog)
Assigned to: Nobody/Anonymous (nobody)
Summary: oldstatus Fix for the message queue

Initial Comment:
This is a fix and generalisation to the away message
queue which is also use to queue message on the docklet
(systray).

Message can now be queued and dequeud without a docklet.

First I have unify the 2 queues (away and docklet) and
put all the queue variables local to away.c, to do this
I had to modify server.c (serv_got_im and
serv_got_update) and docklet.c

-Display Message pending in Docklet tooltip (mainly
plugins/docklet/docklet.c)

-Display Message pending in BuddyList tooltip (gtkblist.c)

-Remove the queued messages when a new conversation is
created (away.c, away.c)

-Add a icon (like the away icon) on buddies with
message(s) pending (gtkblist.c)

-Add a signal for message queued and message dequeued.
(core.c, away.c)

-Add the number of message(s) pending in buddy list
title (blist.c, blist.h, gtkblist.c)

-Update the away tree view with the signals (away.c)

-Reorganize the queue message preferences (gtkpref.c,
docklet.c, server.c, away.c, away.h)

-Add a item to the menu of the buddy list to view all
queued messages (gtkblist.c)

possible enhancements:
-Show in buddy list, contacts with message pending even
if they are offline

-Flash the buddy list when new message arrive and are
queued (in options)

This is for oldstatus but i could port it to HEAD if
there is any interest.

----------------------------------------------------------------------

>Comment By: François Gagné (frenchfrog)
Date: 2005-04-30 14:21

Message:
Logged In: YES 
user_id=1013807

Modified the patch a bit just to include blist.c/blist.h
changes only in gtkblist.c.

Here is the list on the modified files by this patch and the
explanations for each:

-pixmaps/status/default/msgunread.png
image needed to display queued messages on buddies

-pixmaps/status/default/Makefile.am
added the above image to makefile so it get copied to the
build path

-plugins/docklet/docklet.c, plugins/docklet/docklet.h,
plugins/docklet/docklet-win32.c, plugins/docklet/docklet-x11.c
remove queue local variables and added a trigger for
message_queued to update the number of message displayed in
the tooltip docklet

-src/away.c, src/away.h
unified the 2 queues (away and docklet) put all the
variables for the queue local to away.c and thus I added
globals fonctions to manipulate the queue. Also added a
"message-queued" and "message-dequeued" signal

-src/core.c
added to init and unint the fonctions in away.c to register
the signals "message-queued" and "message-dequeued"

-src/gaim.h, src/gtkdialogs.h
removed old globals variables needed for the queues (now
local to away.c)

-gtkblist.c
added connect_signal for the "message-queued" and
"message-dequeued" signal to update the buddy list title and
buddies icon to reflect queued messages

-src/gtkprefs.c
added the new preferences to queue all messages (since the
preference in the docklet have been removed)

-src/server.c (serv_got_im and
serv_got_update)
removed almost all the code related to queues (since moved
to away.c) and call away fonctions instead.




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1192785&group_id=235