[Gaim-patches] [ gaim-Patches-1191553 ] [MSN] msn_p2p_msg() crash fix

[SourceForge.net <no...@so...>]

Patches item #1191553, was opened at 2005-04-28 04:28
Message generated for change (Settings changed) made by lschiere
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1191553&group_id=235

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Evan Schoenberg (evands)
>Assigned to: Stu Tomlinson (nosnilmot)
Summary: [MSN] msn_p2p_msg() crash fix

Initial Comment:
This patch adds g_return_if_fail() safety for the arguments to 
msn_p2p_msg(), bringing it in line with other msn functions and 
hopefully fixing a crash in the process.

It also corrects a comment typo, "its" rather than "it's".

I see a lot of crashes in our crash reporter from MSN which look like:
0   Libgaim                     0x0497b374 msn_p2p_msg   0x3c
1   Libgaim                     0x049771f8 msg_cmd_post   0x64
2   Libgaim                     0x049972a8 read_cb   0x1cc

and usually have descriptions of having been idling and come back 
to find a crash.

I haven't been able to reproduce this crash with the patch, though I 
couldn't reproduce it reliably before, either.

It applies cleanly against oldstatus and HEAD.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1191553&group_id=235