[Gaim-patches] [ gaim-Patches-680803 ] Gadu-Gadu not working when first server port is blocked

[SourceForge.net <no...@so...>]

Patches item #680803, was opened at 2003-02-05 06:31
Message generated for change (Comment added) made by thekingant
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=680803&group_id=235

Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Submitted By: Michal (micu)
Assigned to: Sean Egan (seanegan)
Summary: Gadu-Gadu not working when first server port is blocked

Initial Comment:
When connecting to a Gadu-Gadu server across a firewall
that blocks connections to GG default port (slight
above 8000), switching to alternate (443) is not
handled properly.
I suppose gg_login() function behaves correctly, but
this one is not used right now - gaim uses
proxy_connect() instead.
The quick-and-dirty workaround that I use is to skip
first phase of GG connection and connect immediately to
443 (which is not blocked). Below is mini-patch
implementing such behaviour (against 0.59.8 but as I
far as I can see nothing has changed in GG handling
since then).

Regards
MiCu

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2005-04-24 16:58

Message:
Logged In: YES 
user_id=20979

It looks like this patch is very out of date.  I don't
believe we use any of the connecting code in libgg.c (and it
looks like it's blocking...).  I think all the connecting is
done in gg.c with calls to gaim_proxy_connect.  And it looks
like, to log in, we only attempt to use port 80.  I haven't
heard an astounding number of complaints about this, so I'm
going to assume it's fine for most people.

If you still want to try to fallback to a different port,
feel free to write a new patch that applies to CVS HEAD (but
to me, it seems unneeded).

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-03-13 18:22

Message:
Logged In: YES 
user_id=199625

Are there any downsides to connecting to this port instead?
The comments imply that this is an https port. Unless I'm
mistaken, we don't support SSL with GG. Are there any
potential problems with that?

Also, what about people for whom port 443 is blocked and the
default is?

This would really be better done by making the port
specified in the account editor like it is for every other
prpl. Care to take that task on?

I'll follow your recommendation, regardless, though. Just
because we don't have anyone else interested in GG to
consult with.

----------------------------------------------------------------------

Comment By: Michal (micu)
Date: 2003-02-05 08:25

Message:
Logged In: YES 
user_id=704973


--- src/protocols/gg/libgg.c.ORIG       Sat Dec 21 21:08:19 2002
+++ src/protocols/gg/libgg.c    Wed Feb  5 12:23:54 2003
@@ -1011,7 +1011,7 @@
                        a.s_addr = inet_addr(host);
                        sess->server_ip = a.s_addr;
 
-                       if ((sess->fd = gg_connect(&a, port,
sess->async)) == -1) {
+                       /* if ((sess->fd = gg_connect(&a,
port, sess->async)) == -1) { */
                                gg_debug(GG_DEBUG_MISC, "--
connection failed, trying https connection\n");
                                if ((sess->fd =
gg_connect(&a, GG_HTTPS_PORT, sess->async)) == -1) {
                                    gg_debug(GG_DEBUG_MISC,
"-- connection failed, errno = %d (%s)\n", errno,
strerror(errno));
@@ -1021,7 +1021,7 @@
                                    sess->state = GG_STATE_IDLE;
                                    break;
                                }
-                       }
+                       /* } */
 
                        sess->state = GG_STATE_CONNECTING_GG;
                        sess->check = GG_CHECK_WRITE;


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=680803&group_id=235