Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1167894 ] IRC, Support for 005 PREFIX
|
From: SourceForge.net <no...@so...> - 2005-04-18 04:10:37
|
Patches item #1167894, was opened at 2005-03-21 15:32 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1167894&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Joao Luís Marques Pinto (jpinto) Assigned to: Ethan Blanton (eblanton) Summary: IRC, Support for 005 PREFIX Initial Comment: The following patch will extend the irc plugin with support for the chanmodes specifed on the PREFIX= message. Chanmodes will be stripped from nick's on /names . It will also map the prefix "." to room founder (I am not sure this is common). ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-17 23:10 Message: Logged In: YES user_id=156487 It seems like a bad idea to initialize status_chars with "" and then g_free() that if irc_set_status_chars is called. Also, this patch inserts code in a couple of places that uses spaces to indent when all the surrounding code uses tabs. It should follow the style of the existing code. The mixing of spaces and tabs screws up the indentation. (The placement of the asterisk on irc_get_status_chars in irc.h is also a deviation, albeit a basically irrelevant one.) ---------------------------------------------------------------------- Comment By: Joao Luís Marques Pinto (jpinto) Date: 2005-03-28 09:55 Message: Logged In: YES user_id=21121 The code does set the default prefix chars "@+%" when the irc module is loaded, so it will work even if it doesn't get the 005 . ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-03-25 20:21 Message: Logged In: YES user_id=156487 After a casual reading, I think that you've failed to account for the scenario when a server doesn't send the prefixes with 005. If that happens, you need to fall back to the list of prefix characters that Gaim currently supports. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1167894&group_id=235 |
