Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1180089 ] oscar.c Authorization Dialog Escaping
|
From: SourceForge.net <no...@so...> - 2005-04-16 15:20:00
|
Patches item #1180089, was opened at 2005-04-10 03:55 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 Category: None Group: None Status: Closed Resolution: Invalid Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: oscar.c Authorization Dialog Escaping Initial Comment: I woke up this morning and found another blank dialog box. Some random guy had added me on ICQ it seemed. Anyway, I tracked the bug down to oscar.c. This patch should fix it. Testing shows that I can properly receive authorization messages with HTML special characters (<, >, and &). ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-04-16 11:19 Message: Logged In: YES user_id=20979 You probably want gaim_ssi_authrequest(). The function in your previous patch is called when older (pre-2002) ICQ clients request authorization. I suppose it would be nice if the functionality of those functions were combined into one. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-15 16:54 Message: Logged In: YES user_id=156487 I set a breakpoint on this area of the code and it's not breaking when I have someone send me an ICQ authorization. I'm therefore withdrawing the patch. On that note, do you have any idea where the ICQ authorization dialog is generated? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-10 14:55 Message: Logged In: YES user_id=156487 This was for HEAD. I didn't notice the escaping in gtkrequest.c before. I don't know what's happening. If it's being escaped twice like this suggests, I should've seen < > and & in the dialog box, which I didn't. Something weird is going on. I'll look into it some more. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2005-04-10 09:13 Message: Logged In: YES user_id=309779 is this for HEAD or oldstatus? (HEAD is doing escaping in gtkrequest.c, so this shouldn't be necessary for HEAD, but if it is, something's wrong elsewhere) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 |
