Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1176125 ] Text Replacement Plugin Fixes
|
From: SourceForge.net <no...@so...> - 2005-04-07 14:35:44
|
Patches item #1176125, was opened at 2005-04-03 22:33 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Sean Egan (seanegan) Summary: Text Replacement Plugin Fixes Initial Comment: This patch is based off xkahn's work available at: http://sf.net/support/tracker.php?aid=300235 Most of the changes are his. I just changed his formatting to match the rest of Gaim more closely. Also, I made a couple coding style changes. The two biggest changes I made were: 1) I added some hash stuff to load_config. This removes duplicates. 2) I imported my list of text replacement strings as the default list in addition to xkahn's list. My list consisted primarily of the autocorrect entries from my copy of OpenOffice.org Writer. There were a few things I've added by hand. (For those familiar with my comments in #gaim, this list does NOT include anything like a pwn -> own replacement. If people want to talk like that, I'm not going to stop them. This list should be useful to anyone.) I also fixed a memory leak in load_config. A GtkListStore stores its own copy of strings, so there is no need to g_strdup them when appending to the GtkListStore. When I get a chance, I need to make it give an error if you try to set a duplicate "You type" word in the preferences. Otherwise, this patch should take care of everything. I would recommend considering this patch over xkahn's because it's a direct superset of his patches. However, I want to be very clear that most of the changes in this patch are his and he deserves the credit for them. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 10:35 Message: Logged In: YES user_id=28833 thanks to both of you. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-06 23:20 Message: Logged In: YES user_id=156487 I fixed the problem that xkahn pointed out here. I had discovered that independently; I only saw his posting now. Yes, xkahn, it was fairly simple to fix. I also fixed the last item from my TODO list. It now presents an error if you try to add a duplicate "BAD" word. Finally, I've merged in some more autocorrections from word processors. As I noted in a comment, the ones with spaces don't currently work, but I'm leaving them in case someone modifies the plugin in the future to handle that case. I think it's good enough for me, so I'm not going to put in the work to handle multi-word corrections as that opens a giant can of worms. Oh, this patch also adds Benjamin Kahn to the COPYRIGHT file. This patch should be directly committable now. ---------------------------------------------------------------------- Comment By: Benjamin Kahn (xkahn) Date: 2005-04-03 23:19 Message: Logged In: YES user_id=7632 So there is a major problem with my patch which your patch hasn't fixed yet. I included an "undo" feature which allows users to cancel changes to auto-correct if they hit backspace right after the change is made. The problem is that the undo feature is a little too enthusiastic. It will replace a word if you hit space even after you have moved the cursor. (Possibly only after moving the cursor with the pointer, although I no longer remember.) Also, if you hit backspace to get the word uncorrected, and then hit space again to advance, the word is auto-corrected once more. Not very friendly. This shouldn't be too hard to fix, but I haven't bothered since the patch shows no signs of being incorporated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235 |
