[Gaim-patches] [ gaim-Patches-1176125 ] Text Replacement Plugin Fixes

[SourceForge.net <no...@so...>]

Patches item #1176125, was opened at 2005-04-03 21:33
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Richard Laager (rlaager)
Assigned to: Nobody/Anonymous (nobody)
Summary: Text Replacement Plugin Fixes

Initial Comment:
This patch is based off xkahn's work available at: 
http://sf.net/support/tracker.php?aid=300235 
 
Most of the changes are his. I just changed his formatting to 
match the rest of Gaim more closely. Also, I made a couple 
coding style changes. 
 
The two biggest changes I made were: 
1) I added some hash stuff to load_config. This removes 
duplicates. 
2) I imported my list of text replacement strings as the 
default list in addition to xkahn's list. My list consisted 
primarily of the autocorrect entries from my copy of 
OpenOffice.org Writer. There were a few things I've added 
by hand. (For those familiar with my comments in #gaim, 
this list does NOT include anything like a pwn -> own 
replacement. If people want to talk like that, I'm not going to 
stop them. This list should be useful to anyone.) 
 
I also fixed a memory leak in load_config. A GtkListStore 
stores its own copy of strings, so there is no need to 
g_strdup them when appending to the GtkListStore. 
 
When I get a chance, I need to make it give an error if you 
try to set a duplicate "You type" word in the preferences. 
Otherwise, this patch should take care of everything. 
 
I would recommend considering this patch over xkahn's 
because it's a direct superset of his patches. However, I 
want to be very clear that most of the changes in this patch 
are his and he deserves the credit for them. 
 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235