[Gaim-patches] [ gaim-Patches-1108529 ] Keep formating when a message is sent.

[SourceForge.net <no...@so...>]

Patches item #1108529, was opened at 2005-01-24 13:24
Message generated for change (Comment added) made by belyi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1108529&group_id=235

Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Igor Belyi (belyi)
Assigned to: Sean Egan (seanegan)
Summary: Keep formating when a message is sent.

Initial Comment:
This is similar to "[ 1093125 ] Maintain formatting
between messages within a conversation" but without any
extra Preferences. I consider it a bug fixing patch.
Please, feel free to disagree. :o)

Markup buttons (bold, italic, underline, font) are
triggered back into some predefined state even when
"Default Formatting" is not checked in the "Message
Text" of the Preferences. The attached patch fixes this
problem. With this patch markup state get reset to the
predefined in this preference format only when "Default
Formatting" is checked.

I hope you like it.
Igor


----------------------------------------------------------------------

>Comment By: Igor Belyi (belyi)
Date: 2005-03-15 22:02

Message:
Logged In: YES 
user_id=995711

I apologize for not replying for so long.

No, this patch does not address the problem of the text
being green all the time - it solves completely different
problem of the text always returning to some predefined
state even if you don't want to.

Do you still want me to redo the patch against CVS?

Regarding text being green - do you know that different chat
protocols support different text markups? IM, for example
supports formating only of the whole text. Therefore, if you
change formating of the text to green - the whole buffer
should become green since this is how your text will be seen
to your reader. Other protocols do not allow markups at all
and therefore if you have account in them and still able to
change formating - this can be considered a bug since for
those protocols all formating buttons should be disabled.

Cheers,
Igor


----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-03-07 13:58

Message:
Logged In: YES 
user_id=199625

I'm going to commit this and see if I can't make sure the
bug is fixed myself.

Thanks, Igor. :)

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-02-27 17:27

Message:
Logged In: YES 
user_id=199625

Just for clarification:

The current problem with me accepting this feature is
there's currently no good way to remove formatting once it's
already there. For instance, I've pasted green text into the
GtkIMHtml before and then whatever I type after that is
still green.

If this patch doesn't address that, everything I type after
pasting green text will be green, despite that I only wanted
the few words I pasted to be green.

Is that fixed by this patch? Also, could you make a patch
against CVS HEAD?

-s.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1108529&group_id=235