[Gaim-patches] [ gaim-Patches-1154809 ] conversation features

[SourceForge.net <no...@so...>]

Patches item #1154809, was opened at 2005-03-01 23:52
Message generated for change (Comment added) made by taliesein
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1154809&group_id=235

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Christopher (siege) O'Brien (taliesein)
Assigned to: Nobody/Anonymous (nobody)
Summary: conversation features

Initial Comment:
This patch modifies conversations to support modifiable
features.

Normally, the features for a conversation are based off
of those specified in the appropriate GaimConnection
(eg, whether it's plaintext or formatted, are
line-breaks permitted, etc).

With this patch, conversations are created by default
with the features specified in the GaimConnection, but
those features can be modified per-conversation. Thus,
if all conversations for a protocol do not support HTML
or images by default, but have some instance where they
should support those features, the conversation
features can be updated to reflect this.

AIM is a good example, as they do not normally support
images, unless in a DC. Thus, the GaimConnection could
indicate no images, and individual GaimConversations
based off of a DC could turn the feature on.

This is also very useful for Meanwhile, as normally the
protocol is plaintext... unless talking to NotesBuddy
(or other Meanwhile users pretending to use
NotesBuddy), in which case it's got HTML and images and
rainbows and unicorns and cotton-candy etc etc. I wrote
this for the cotton-candy, actually.

As this adds features, I gather it may be something
that needs to be incorporated into a minor release,
rather than a micro. There's also a field added to the
GaimConversation structure, so... that could be a problem.

I've tested the attached patch with my own use for a
week or so, and it seems to be working alright.

----------------------------------------------------------------------

>Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-03-02 15:00

Message:
Logged In: YES 
user_id=77326

summary of API changes:

connection.h

	GaimConnectionFlags
	- added GAIM_CONNECTION_NO_IMAGES

conversation.h

	GaimConversation
	- added GaimConnectionFlags features

	GaimConvChatBuddyFlags
	- added GAIM_CBFLAGS_TYPING

	Functions
	- added gaim_conversation_set_features
	- added gaim_conversation_get_features


----------------------------------------------------------------------

Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-03-01 23:58

Message:
Logged In: YES 
user_id=77326

better patch

----------------------------------------------------------------------

Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-03-01 23:52

Message:
Logged In: YES 
user_id=77326

I should mention, this patch is against oldstatus, not HEAD

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1154809&group_id=235