Re: [Gaim-devel] GTK and parent widgets

[Robert M. <rob...@de...>]

On Sun, Apr 06, 2003 at 09:49:18AM -0400, Decklin Foster wrote:
> Cleanice (the GTK theme) was segfaulting whenever gtkimhtml popped up a
> tooltip. I tracked it down to a line like this:
> 
> strstr (g_type_name (GTK_WIDGET_TYPE (widget->parent)), "CheckButton")
> 
> where widget->parent was NULL. This is the only widget I've seen this
> problem with, but I'm not familiar enough with GTK internals (or used to
> sort of vaguely be, but then 2.0 came out) to understand who's at fault
> here. Is it a bug in gaim, for not giving the widget a parent? (It was
> not immediately apparent how to fix that.) Or should cleanice not assume
> there will be one?
> 
> This happens inside the gtk_paint_layout call on line 1327.

Funny, we fixed the exact same problem with the blist tooltips. It's a
bug in both Gaim and in Cleanice. Our bug for making tooltip windows
without setting the parent like Gtk does on it's tooltip windows, and
Cleanice for not checking parent was a valid pointer before
dereferencing it. Cleanice's problem is fixed in their CVS, so it
shouldn't crash, and we fixed it in the case of the buddy list so it
doesn't tickle that bug in released Cleanice versions anyway. See:
 http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gaim/gaim/src/buddy.c.diff?r1=1.463&r2=1.464

I'd guess we just need to do the same with our GtkIMHtml tooltips too.

Regards,
Rob