From: Robert M. <rob...@de...> - 2003-02-01 19:39:00
|
On Sat, Feb 01, 2003 at 10:14:16AM -0500, John Palmieri wrote: > I took a quick look at the code and tried to do a quick fix to no > avail. Seems like I can't even get the docklet plugin to show up in the > plugins menu anymore. This is even when I remove any changes I did. > Any suggestions? > > -- > J5 What? It's called 'Tray Icon' now. And no, it's not a quick-fix-able thing, otherwise I would've quick-fixed it already. If we're talking about the login window, it's created at startup before the main loop is started. This means the events which filter through and create the docklet icon etc have not been processed, so it's like a race condition. To fix we'd need to either make the decision as to whether to show the login window some time later (in a timeout (hack) or a low-priority idle handler (not so bad)), or (ugh) make the docklet hide a login window when the icon is displayed (hack!). For the blist it's not just a race. Except at auto-login time, we can assume the docklet to be fully displayed when it comes to the blist being created or not. The problem is that if we defer creation of the blist window, lots of other code which refers to it (icon switching, menu re-generation) fails horribly. And, because of the shonky blist gtk code, we can't create it without showing it. Frankly, I'm surprised the blist works at all. Try and change anything with regard to when the blist is created etc, and watch Gaim crash. I'm not going to invest much time in this until the blist has been rewritten. Hopefully in so doing it will be made less crap too. Regards, Rob |