From: Ray S. <hal...@ha...> - 2003-01-02 15:44:08
|
> > >Is there some event we can hook to when the Browser pane is switched away from, as well as the obvious dialog box closure? > > Yes I believe so. I can change it to not have the buttons, if that way is better. >Copyright aside (I've suspected browser.c for about a year =), I think >we can drop netscape support. It's ugly, it has questionable copyright, >the browser sucks, there are plenty popular free replacements, nobody >ships it any more, and nobody I know uses it. GNOME dropped it too >(they had a helper called gnome-moz-remote which they canned in >GNOME2). Anyone object if we just drop Netscape support? We could nuke >browser.c and put the URL function in util.c then. =) > > I was thinking along those same lines until someone on IRC said that the protocol has come pretty standard among the browsers (It works with Netscape, Mozilla, and Opera at least). Also, the protocol doesnt require the browser run on the same machine as gaim (they just have to be using the same display server). I think that is a neat feature. I think maybe the code just needs to be cleaned up and restructured. All the X stuff should be moved to its own source file, and the interface (netscape_command() currently) should allow more than one request at a time (Set up a queue, also, use any available netscape windows and not just the first one found). I still think we should investigate the possible issues arisen from mixing this code with GPLd though and possibly move certain functionality to a helper application. >With the patch, you seem to have reverted a bunch of gtk_signal_connect >-> g_signal_connect changes that have been made in CVS. > Oops, sorry about that. My cvs tree was screwed up. The attached patches should play nicer. --Ray Strode |