From: Ray S. <hal...@ha...> - 2003-01-02 06:05:51
|
Attached are two patches. One of the patches hides browsers that arent installed from the preferences menu. It also adds a Set and Reset button to the Manual browser entry, so that the entry can be validated, too. The other patch switches browser.c over to the g_spawn_* api, adds error messages, and fixes a bug that was preventing the gaim interface from redrawing under certain situations if Netscape is the configured browser. Note I cant get netscape 4.x to work on my computer, so I wasnt able to test it with that browser (and there is some pretty complicated code for talking to that browser). Another issue. It seems that browser.c currently uses some code that is from netscape/jwz and the original code specifies that the copyright and permission notice must remain in tact. browser.c has the copyright notice, but it doesnt have the permission notice. Furthermore, I dont think it could because it conflicts with the gpl. Also, the offending code has to jump through some hoops to coexist with Gtk+ and it really is quite ugly. I think it would be better to just bundle a helper program with gaim and use that if netscape is installed (maybe use the program that the code was taken from). That solves the GPL issue and the asthetics issue. --Ray Strode |