[Gaim-devel] Some patches (docklet tweaks, session management)

[Robert M. <rob...@de...>]

NB: For 'docklet', read 'tray icon'. Old habits die hard. =)

I found and fixed a little bug with the updating of the docklet's
connecting icon to the offline/online icon when you cancel the
connection process. The gist of it was that the connecting counter is
decremented after the plugin event for signoff is called, so that the
plugins are able to tell the connection was never fully established (for
whatever reason - this is just the way I did it =). Ironically for me,
my forethought backfired on the docklet, because it does need to know
when all the "connecting" gcs are gone, so it can set the right icon.
The fix is just to update the status in the g_idle handler, so it
happens after the connecting counter is decremented.

While I was there I got carried away and made the docklet menu all
purty, in the code and in the flesh. It now has icons like the buddy
list menus do, and the code is less iffy (in the sense of using if, and
in the sense of falling through incorrectly for some statuses) and more
switchy, which means it catches all the cases correctly. Yay!

Patch for this is at:
 http://people.debian.org/~robot101/docklet-purty-menu-and-fixed-icon.diff

And at the risk of harping on, I laboured one night and day to enable
Gaim to connect to a session manager (such as gnome-session) so that
when you log out (of GNOME for instance =) with Gaim running, it's
running the next time you log in. Once I've straightened a few other
things out, I anticipate adding the ability for it to save the state of
your accounts at log out, and restore them at log in, and also to allow
people to save their state at any time, so they can have presets for
'online' or 'invisible' or 'away', for example. In the meantime, I'd
appreciate people trying out the session management stuff if they use
KDE, GNOME, or even xsm.

The glue patch is at:
 http://people.debian.org/~robot101/sm-me-harder6.diff
And you need to put this file in the src/ directory:
 http://people.debian.org/~robot101/session.c
(and spot the minor warning fix in about.c =)

I'd appreciate it if anyone committed either or both of these.

Regards,
Rob