[Gaim-devel] Patch: OFT cleanup

[William T. M. <wt...@du...>]

Hello,

Here is a patch that cleans up some remaining unsightliness in my FT
code, and (I hope) makes it easer to follow.  It touches several
files but changes no functionality.

* Replace all uses of conn->priv in ft.c with conn->internal, as
  recommended by the libfaim comments
* Add brief comments describing each of the FT functions
* Remove a few glib functions that I carelessly introduced into
  ft.c with my FT patch (yes, glib is cool, but I understand libfaim
  has always been glib-free and it's easy to keep it that way)
* Replace various hard-coded constants in with macros
* Rename the FT functions in oscar.c to make them consistent with
  the prpl hooks
* Move struct aim_filetransfer_priv from aim.h into ft.c, where
  it belongs
* Use separate callback types for sendfile rather than co-opting
  the getfile ones; pass the whole file header to the callbacks rather
  than just a few of the fields

-- Wil
P.S.  I hope I'm not bombarding the list with patches.  I anticipate
sending one or two more before the Oscar protocol code is reasonably
complete, although the generic FT interface could obviously use some
work.