Re: [Gaim-devel] new version of the GtkTextView/GtkTextBuffer patch

[David O. <Da...@di...>]

On Fri, Oct 18, 2002 at 09:57:58PM -0500, Ethan Blanton wrote:
> Nathan Walp spake unto us the following wisdom:
> > I wrote something about the patch earlier, but it was too big, so it's
> > waiting on moderation.  here's the link:
> > 
> > http://faceprint.com/code/gaim/gtk2-input-with-typing.diff
> 
> And I also sent a counter-patch that got held up by moderation.  :-P
> 
> http://irg.cs.ohiou.edu/~eblanton/gaim-patches/gaim-cvs-dindinx-with-typing.diff
> 
> This patch is:
>   * David Odin's gtk2 input patch
>   * Nathan Walp's typing notification cleanups
>   * My cleanup of David's patch plus a pretty recessed frame around
>     the GtkTextInput widget.
> 
> My personal opinion is that this is ready for inclusion.  It has some   
> outstanding issues (enter-to-send does not work with XIM, for one), 
> but it is approximately 10000x better than what we have right now.
> I'd like to get it in and get the bugs beaten out as soon as possible. 
>        
  Great. I have just a few remarks:

- You've put the input entry above the iconbar.  Is this on purpose?  I
  tend to prefer the iconbar above the entry.
- You've replace the 'entry_view' field by 'entry'.  I guess it was to
  reduce the patch size.  I'm afraid this could cause some hard-to-find
  bugs because the 'entry' field can be used with its former meaning
  (i.e a pointer to a GtkText, not a GtkTextView) by other part of
  gaim's code.

Anyway, this two issues could be looked at afterward.


       Regards,

             DindinX


-- 
Da...@di...
You know it's Monday when you wake up and it's Tuesday.
		-- Garfield