[Gaim-devel] YIM crash [patch]

[Daniel D. <dan...@dr...>]

I get the following backtrace when trying to use YIM + gaim 0.59.4:

#0  0x40579310 in __strncasecmp (s1=0x0, s2=0x407c2d1a "TYPING", n=6)
    at ../sysdeps/generic/strncase.c:68
#1  0x40476a90 in g_strncasecmp (s1=0x0, s2=0x407c2d1a "TYPING", n=6)
    at gstrfuncs.c:1226
#2  0x407bcfc3 in yahoo_process_notify (gc=0x820b400, pkt=0x8233650)
    at yahoo.c:528
...

it looks like yahoo is sending out notifications without a msg field, so the
following patch just aborts the notification processing for such packets:

I am able to use YIM after this patch is applied

--- src/protocols/yahoo/yahoo.c.orig	Tue Oct  1 15:36:23 2002
+++ src/protocols/yahoo/yahoo.c	Tue Oct 15 15:47:23 2002
@@ -524,7 +524,10 @@
 			game = pair->value;
 		l = l->next;
 	}
-	
+
+	if (!msg)
+		return;	
+
 	if (!g_strncasecmp(msg, "TYPING", strlen("TYPING"))) {
 		if (*stat == '1')
 			serv_got_typing(gc, from, 0);

-- 
It's looking like if MySQL AB doesn't make a movie based on the manual,
nobody's ever gonna learn how to use a database.
        - r.