Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1122730 ] compact placing in smiley popup
|
From: SourceForge.net <no...@so...> - 2005-02-15 11:05:58
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
