Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1097844 ] In MSN and Yahoo, cannot show some filenames and messages
|
From: SourceForge.net <no...@so...> - 2005-01-09 09:01:15
|
Patches item #1097844, was opened at 2005-01-07 22:02 Message generated for change (Comment added) made by tfujiwara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1097844&group_id=235 Category: i18n Group: None Status: Open Resolution: None Priority: 5 Submitted By: fujiwara (tfujiwara) Assigned to: Ethan Blanton (eblanton) Summary: In MSN and Yahoo, cannot show some filenames and messages Initial Comment: In MSN and Yahoo, cannot show some filenames and messages in non-UTF-8 locales. CASE1: 1. Invoke gaim on ja_JP.eucJP. 2. Create an account of MSN. 3. Log into MSN with the account. 4. Click [Buddies] -> [New Instant Message] and launch [New Instant Message] dialog. 5. Input the a buddy account name and connect to MSN. e.g. $acc...@ho... 6. Choose [Conversation] -> [Send File] button in the IM window. 7. Send any files with the current locale filename to the buddy and lauch [File Transfers] dialog. Then the filename is not shown. CASE2: 8. The buddy receive the notification from the sender. 9. The buddy reject the file. Then the error dialog "%s canceled the transfer of %s" cannot shown the localized filename. CASE3: 1. Invoke gaim. 2. Create an account of MSN. 3. Log into MSN with the account and connect to a buddy with IM. 4. Chat the buddy with localized chars. 5. Choose [Conversation] -> [Save As...] and save the log. 6. View the file with GNOME-Terminal. The the header of the file cannot show the localized chars. CASE4: 1. Invoke gaim. 2. Create an account of MSN. 3. Input the account and the wrong password and fail to log into MSN. Then the following messages are not localized. "Type your e-mail address and password correctly. If you haven't registered with .NET Passport, click the Get a .NET Passport link." CASE5: 1. Invoke gaim. 2. Create an account of MSN. 3. Log into MSN with the account and launch [Buddy List] window. 4. Choose [Buddies] -> [Add Buddy...] and open the [Add Buddy] window. Then the "Individuals" is not localized. CASE6: 1. Invoke gaim on ja_JP.eucJP. 2. Create an account of Yahoo. 3. Log into Yahoo with the account 4. Click [IM] button in the [Buddy List] window and connect to myself with IM. 4. Click [Send File] button and send any files with the current encoding filename to myself. Then received filename are not localized. I attached the patch. I also note the POTFILES.in patch below. --- gaim-0.82.1/po/POTFILES.in.orig 2004-01-07 11:27:02.734248328 +0900 +++ gaim-0.82.1/po/POTFILES.in 2004-01-07 11:28:12.975570024 +0900 @@ -1,12 +1,10 @@ +gaim.desktop.in plugins/autorecon.c -plugins/chkmail.c -plugins/contact_priority.c plugins/docklet/docklet-win32.c plugins/docklet/docklet.c plugins/extplacement.c plugins/filectl.c plugins/gaim-remote/remote.c -plugins/gaiminc.c plugins/gestures/gestures.c plugins/gevolution/add_buddy_dialog.c plugins/gevolution/assoc-buddy.c @@ -16,8 +14,6 @@ plugins/history.c plugins/iconaway.c plugins/idle.c -plugins/ipc-test-client.c -plugins/ipc-test-server.c plugins/mailchk.c plugins/notify.c plugins/perl/perl.c @@ -66,7 +62,6 @@ src/plugin.c src/prefs.c src/protocols/gg/gg.c -src/protocols/icq/gaim_icq.c src/protocols/irc/cmds.c src/protocols/irc/dcc_send.c src/protocols/irc/irc.c @@ -115,6 +110,7 @@ src/protocols/novell/nmuser.c src/protocols/novell/novell.c src/protocols/oscar/oscar.c +src/protocols/rendezvous/rendezvous.c src/protocols/silc/buddy.c src/protocols/silc/chat.c src/protocols/silc/ft.c ---------------------------------------------------------------------- >Comment By: fujiwara (tfujiwara) Date: 2005-01-09 18:01 Message: Logged In: YES user_id=1192233 CASE1: This case is not only MSN but also Yahoo is applied. So I think Gaim needs to provide the fix for non-UTF-8 locales. After this fix is applied, each module can choose to send UTF-8 filename only or not. Actually, when send non-UTF-8 filename, MS Messenger can handle the filename in Windows side so to send non-UTF-8 local is no problem. I think the solutions is: If users send files on UTF-8 locales, almost filename will be UTF-8 so it is no problem. If users want to send files on non-UTF-8 locales, the filename will be non-UTF-8 and it will be an expected behavior. i.e. Yahoo protocol is used between Unix users. so the comatibility is needed. Then users can select the behaviors by my patch: % env LANG=ja_JP.eucJP LC_ALL=ja_JP.eucJP gaim CASE2: it is the similar of CASE1. CASE3: it is an obvious bug. the log file is mixed UTF-8 strings and non-UTF-8 strings. the header is non-UTF-8 strings but the IM contents are UTF-8 strings. So my patch needs to be applied. CASE4: Sorry I don't know what do you mean. CASE6: Users expect this application is used in Yahoo. too. If not, the proper action is to remove all Yahoo modules in Gaim. Could you apply my attached patch to gaim? It can resolve all the issues. Thanks. ---------------------------------------------------------------------- Comment By: Eduardo Pérez (eperez) Date: 2005-01-09 06:00 Message: Logged In: YES user_id=60347 CASE1: I think the official MSN client gets and sends UTF-8 encoded filenames. If gaim is sending non UTF-8 encoded filenames then that's a bug. Gaim should check that the filename is UTF-8 valid, if not then it should convert it from the locale and then send it. CASE2: If gaim is not sending a UTF-8 encoded filename when it should then this problem is expected. CASE3: logs are UTF-8. That's not a bug. You can convert with iconv -f UTF-8 -t EUCJP file CASE4: I don't care. CASE5: "Individuals" is a special MSN group, but it should be localized. CASE6: I don't use yahoo. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1097844&group_id=235 |
