[Gaim-commits] SF.net SVN: gaim: [18227] trunk/libgaim/protocols/jabber/buddy.c

[<the...@us...>]

Revision: 18227
          http://svn.sourceforge.net/gaim/?rev=18227&view=rev
Author:   thekingant
Date:     2007-04-01 11:59:15 -0700 (Sun, 01 Apr 2007)

Log Message:
-----------
sf patch #1684297, from Atamyrat Hezretguliyev

This patch fixes a bug in buddy.c, jabber_buddy_remove_id function.
l->data is accessed after l is freed, which crashes GAIM.

Modified Paths:
--------------
    trunk/libgaim/protocols/jabber/buddy.c

Modified: trunk/libgaim/protocols/jabber/buddy.c
===================================================================
--- trunk/libgaim/protocols/jabber/buddy.c	2007-04-01 17:37:40 UTC (rev 18226)
+++ trunk/libgaim/protocols/jabber/buddy.c	2007-04-01 18:59:15 UTC (rev 18227)
@@ -732,8 +732,9 @@
 
 	while(l) {
 		if(!strcmp(id, l->data)) {
+			gpointer tmp = l->data;
 			jbi->ids = g_slist_remove(jbi->ids, l->data);
-			g_free(l->data);			
+			g_free(tmp);
 			return;
 		}
 		l = l->next;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.