[Gaim-commits] SF.net SVN: gaim: [17866] trunk

[<the...@us...>]

Revision: 17866
          http://svn.sourceforge.net/gaim/?rev=17866&view=rev
Author:   thekingant
Date:     2006-12-01 00:07:17 -0800 (Fri, 01 Dec 2006)

Log Message:
-----------
Get rid of a bunch of compile warnings

Modified Paths:
--------------
    trunk/gtk/gtkaccount.c
    trunk/libgaim/account.h
    trunk/libgaim/dbus-server.c
    trunk/libgaim/plugins/log_reader.c
    trunk/libgaim/protocols/msn/userlist.c
    trunk/libgaim/protocols/oscar/oscar.c

Modified: trunk/gtk/gtkaccount.c
===================================================================
--- trunk/gtk/gtkaccount.c	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/gtk/gtkaccount.c	2006-12-01 08:07:17 UTC (rev 17866)
@@ -2381,8 +2381,8 @@
 }
 
 struct auth_and_add {
-	void(*auth_cb)(void*);
-        void(*deny_cb)(void*);
+	GaimAccountRequestAuthorizationCb auth_cb;
+	GaimAccountRequestAuthorizationCb deny_cb;
 	void *data;
 	char *username;
 	char *alias;
@@ -2440,8 +2440,8 @@
 
 	if (!gaim_find_buddy(account, remote_user)) {
 		struct auth_and_add *aa = g_new0(struct auth_and_add, 1);
-		aa->auth_cb = auth_cb;
-		aa->deny_cb = deny_cb;
+		aa->auth_cb = (GaimAccountRequestAuthorizationCb)auth_cb;
+		aa->deny_cb = (GaimAccountRequestAuthorizationCb)deny_cb;
 		aa->data = user_data;
 		aa->username = g_strdup(remote_user);
 		aa->alias = g_strdup(alias);

Modified: trunk/libgaim/account.h
===================================================================
--- trunk/libgaim/account.h	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/libgaim/account.h	2006-12-01 08:07:17 UTC (rev 17866)
@@ -34,6 +34,7 @@
 typedef struct _GaimAccount      GaimAccount;
 
 typedef gboolean (*GaimFilterAccountFunc)(GaimAccount *account);
+typedef void (*GaimAccountRequestAuthorizationCb)(void *);
 
 #include "connection.h"
 #include "log.h"

Modified: trunk/libgaim/dbus-server.c
===================================================================
--- trunk/libgaim/dbus-server.c	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/libgaim/dbus-server.c	2006-12-01 08:07:17 UTC (rev 17866)
@@ -668,7 +668,6 @@
 		guint xuint;
 		gboolean xboolean;
 		gpointer ptr = NULL;
-		gboolean allocated = FALSE;
 
 		if (gaim_value_is_outgoing(gaim_values[i]))
 		{
@@ -693,13 +692,14 @@
 		case GAIM_TYPE_STRING:
 			str = null_to_empty(my_arg(char*));
 			if (!g_utf8_validate(str, -1, NULL)) {
+				gchar *tmp;
 				gaim_debug_error("dbus", "Invalid UTF-8 string passed to signal, emitting salvaged string!\n");
-				str = gaim_utf8_salvage(str);
-				allocated = TRUE;
+				tmp = gaim_utf8_salvage(str);
+				dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &tmp);
+				g_free(tmp);
+			} else {
+				dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &str);
 			}
-			dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &str);
-			if (allocated)
-				g_free(str);
 			break;
 		case GAIM_TYPE_SUBTYPE: /* registered pointers only! */
 		case GAIM_TYPE_POINTER:

Modified: trunk/libgaim/plugins/log_reader.c
===================================================================
--- trunk/libgaim/plugins/log_reader.c	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/libgaim/plugins/log_reader.c	2006-12-01 08:07:17 UTC (rev 17866)
@@ -1640,7 +1640,7 @@
 					while (*line2 && *line2 != ':')
 						line2++;
 					if (*line2 == ':') {
-						char *acct_name;
+						const char *acct_name;
 						line2++;
 						line = line2;
 						acct_name = gaim_account_get_alias(log->account);

Modified: trunk/libgaim/protocols/msn/userlist.c
===================================================================
--- trunk/libgaim/protocols/msn/userlist.c	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/libgaim/protocols/msn/userlist.c	2006-12-01 08:07:17 UTC (rev 17866)
@@ -74,7 +74,7 @@
 	pa->gc = gc;
 	
 	gaim_account_request_authorization(gaim_connection_get_account(gc), passport, NULL, friendly, NULL,
-					   msn_accept_add_cb, msn_cancel_add_cb, pa);
+					   G_CALLBACK(msn_accept_add_cb), G_CALLBACK(msn_cancel_add_cb), pa);
 }
 
 /**************************************************************************

Modified: trunk/libgaim/protocols/oscar/oscar.c
===================================================================
--- trunk/libgaim/protocols/oscar/oscar.c	2006-12-01 07:07:22 UTC (rev 17865)
+++ trunk/libgaim/protocols/oscar/oscar.c	2006-12-01 08:07:17 UTC (rev 17866)
@@ -2330,8 +2330,9 @@
 				data->name = sn;
 				data->nick = NULL;
 
-				gaim_account_request_authorization(gaim_connection_get_account(gc), sn, NULL, NULL, reason,
-						G_CALLBACK(gaim_auth_grant), G_CALLBACK(gaim_auth_dontgrant_msgprompt), data);
+				gaim_account_request_authorization(account, sn,
+						NULL, NULL, reason,	G_CALLBACK(gaim_auth_grant),
+						G_CALLBACK(gaim_auth_dontgrant_msgprompt), data);
 				g_free(reason);
 			}
 		} break;
@@ -5041,8 +5042,9 @@
 	data->name = g_strdup(sn);
 	data->nick = NULL;
 
-	gaim_account_request_authorization(gaim_connection_get_account(gc), nombre, NULL, NULL, reason,
-			G_CALLBACK(gaim_auth_grant), G_CALLBACK(gaim_auth_dontgrant_msgprompt), data);
+	gaim_account_request_authorization(account, nombre,
+			NULL, NULL, reason, G_CALLBACK(gaim_auth_grant),
+			G_CALLBACK(gaim_auth_dontgrant_msgprompt), data);
 	g_free(nombre);
 	g_free(reason);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.