From: <the...@us...> - 2006-11-28 06:59:48
|
Revision: 17834 http://svn.sourceforge.net/gaim/?rev=17834&view=rev Author: thekingant Date: 2006-11-27 22:59:48 -0800 (Mon, 27 Nov 2006) Log Message: ----------- I don't think these parameters are allowed to be null... it looks like it can cause crashes. See Red Hat bug #217335. Thanks to Nalin Dahyabhai for pin pointing the cause of the crash. http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217335 Modified Paths: -------------- trunk/libgaim/protocols/jabber/auth.c Modified: trunk/libgaim/protocols/jabber/auth.c =================================================================== --- trunk/libgaim/protocols/jabber/auth.c 2006-11-28 06:37:12 UTC (rev 17833) +++ trunk/libgaim/protocols/jabber/auth.c 2006-11-28 06:59:48 UTC (rev 17834) @@ -753,7 +753,9 @@ * should try one more round against it */ if (js->sasl_state != SASL_OK) { - js->sasl_state = sasl_client_step(js->sasl, NULL, 0, NULL, NULL, NULL); + const char *c_out; + unsigned int clen; + js->sasl_state = sasl_client_step(js->sasl, NULL, 0, NULL, &c_out, &clen); if (js->sasl_state != SASL_OK) { /* This should never happen! */ gaim_connection_error(js->gc, _("Invalid response from server.")); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |