[Gaim-commits] SF.net SVN: gaim: [17440] trunk/console/gntconv.c

[<nos...@us...>]

Revision: 17440
          http://svn.sourceforge.net/gaim/?rev=17440&view=rev
Author:   nosnilmot
Date:     2006-10-07 10:09:14 -0700 (Sat, 07 Oct 2006)

Log Message:
-----------
Fix Coverity CID 291 - don't dereference conv before the NULL check

Modified Paths:
--------------
    trunk/console/gntconv.c

Modified: trunk/console/gntconv.c
===================================================================
--- trunk/console/gntconv.c	2006-10-07 17:05:27 UTC (rev 17439)
+++ trunk/console/gntconv.c	2006-10-07 17:09:14 UTC (rev 17440)
@@ -234,11 +234,12 @@
 	char *title, *old_title;
 
 	conv = gaim_find_conversation_with_account(GAIM_CONV_TYPE_IM, who, account);
-	im = GAIM_CONV_IM(conv);
 
 	if (!conv)
 		return;
 
+	im = GAIM_CONV_IM(conv);
+
 	if (gaim_conv_im_get_typing_state(im) == GAIM_TYPING) {
 		old_title = get_conversation_title(conv, account);
 		title = g_strdup_printf(_("%s [%s]"), old_title,


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.