[Gaim-commits] SF.net SVN: gaim: [17190] trunk/libgaim/proxy.c

[<the...@us...>]

Revision: 17190
          http://svn.sourceforge.net/gaim/?rev=17190&view=rev
Author:   thekingant
Date:     2006-09-07 23:17:59 -0700 (Thu, 07 Sep 2006)

Log Message:
-----------
Comment change

Modified Paths:
--------------
    trunk/libgaim/proxy.c

Modified: trunk/libgaim/proxy.c
===================================================================
--- trunk/libgaim/proxy.c	2006-09-08 06:07:19 UTC (rev 17189)
+++ trunk/libgaim/proxy.c	2006-09-08 06:17:59 UTC (rev 17190)
@@ -888,11 +888,12 @@
 			else
 			{
 				/*
-				 * TODO: Uh, is this a good idea?  For something like
-				 *       oscar, for example, we end up sending binary
-				 *       oscar protocol data to the proxy server, which
-				 *       has no idea what we're talking about, since
-				 *       the proxy server is expecting an HTTP request.
+				 * If we're trying to connect to something running on
+				 * port 80 then we assume the traffic using this
+				 * connection is going to be HTTP traffic.  If it's
+				 * not then this will fail (uglily).  But it's good
+				 * to avoid using the CONNECT method because it's
+				 * not always allowed.
 				 */
 				gaim_debug_info("proxy", "HTTP proxy connection established\n");
 				gaim_proxy_connect_data_connected(connect_data);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.