[Gaim-commits] SF.net SVN: gaim: [17180] trunk/libgaim/dnsquery.c

[<the...@us...>]

Revision: 17180
          http://svn.sourceforge.net/gaim/?rev=17180&view=rev
Author:   thekingant
Date:     2006-09-06 03:06:58 -0700 (Wed, 06 Sep 2006)

Log Message:
-----------
Don't allow dns lookups of empty strings

Modified Paths:
--------------
    trunk/libgaim/dnsquery.c

Modified: trunk/libgaim/dnsquery.c
===================================================================
--- trunk/libgaim/dnsquery.c	2006-09-06 10:04:34 UTC (rev 17179)
+++ trunk/libgaim/dnsquery.c	2006-09-06 10:06:58 UTC (rev 17180)
@@ -591,6 +591,12 @@
 	query_data->data = data;
 	query_data->resolver = NULL;
 
+	if (strlen(query_data->hostname) == 0)
+	{
+		gaim_dnsquery_destroy(query_data);
+		g_return_val_if_reached(NULL);
+	}
+
 	if (!queued_requests)
 		queued_requests = g_queue_new();
 	g_queue_push_tail(queued_requests, query_data);
@@ -757,6 +763,12 @@
 	query_data->error_message = NULL;
 	query_data->hosts = NULL;
 
+	if (strlen(query_data->hostname) == 0)
+	{
+		gaim_dnsquery_destroy(query_data);
+		g_return_val_if_reached(NULL);
+	}
+
 	/* Don't call the callback before returning */
 	query_data->timeout = gaim_timeout_add(0, resolve_host, query_data);
 
@@ -812,6 +824,7 @@
 
 	g_return_val_if_fail(hostname != NULL, NULL);
 	g_return_val_if_fail(port     != 0, NULL);
+	g_return_val_if_fail(callback != NULL, NULL);
 
 	query_data = g_new(GaimDnsQueryData, 1);
 	query_data->hostname = g_strdup(hostname);
@@ -820,6 +833,12 @@
 	query_data->callback = callback;
 	query_data->data = data;
 
+	if (strlen(query_data->hostname) == 0)
+	{
+		gaim_dnsquery_destroy(query_data);
+		g_return_val_if_reached(NULL);
+	}
+
 	/* Don't call the callback before returning */
 	query_data->timeout = gaim_timeout_add(0, resolve_host, query_data);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.