[Gaim-commits] SF.net SVN: gaim: [17167] trunk/libgaim/plugins/tcl/tcl_signals.c

[<ebl...@us...>]

Revision: 17167
          http://svn.sourceforge.net/gaim/?rev=17167&view=rev
Author:   eblanton
Date:     2006-09-05 06:55:50 -0700 (Tue, 05 Sep 2006)

Log Message:
-----------
Breaking from case statements to prevent fall-through which causes an
extra va_arg to be extracted is kind of important.  I think I'll do
that here.  (Thanks to Josh Blanton)

Modified Paths:
--------------
    trunk/libgaim/plugins/tcl/tcl_signals.c

Modified: trunk/libgaim/plugins/tcl/tcl_signals.c
===================================================================
--- trunk/libgaim/plugins/tcl/tcl_signals.c	2006-09-05 08:21:51 UTC (rev 17166)
+++ trunk/libgaim/plugins/tcl/tcl_signals.c	2006-09-05 13:55:50 UTC (rev 17167)
@@ -224,6 +224,7 @@
 			} else {
 				arg = Tcl_NewIntObj(va_arg(args, int));
 			}
+			break;
 		case GAIM_TYPE_INT64:
 		case GAIM_TYPE_UINT64:
 			/* Tcl < 8.4 doesn't have wide ints, so we have ugly


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.