[Gaim-commits] SF.net SVN: gaim: [16583] trunk/src/protocols/gg/gg.c

[<ev...@us...>]

Revision: 16583
Author:   evands
Date:     2006-07-27 10:37:42 -0700 (Thu, 27 Jul 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16583&view=rev

Log Message:
-----------
Fix a crash when gadu-gadu signs off while a search is still open.  It destroys its search HashTable in its close() function, and that table is accessed when gaim_notify_close_with_handle() is called.  An alternative fix would be for the close_with_handle() functions to be called before prpl_info->close() in connection.c, but I'm not positive that this wouldn't cause problems with other prpls, so I went for a smaller-impact change.  I'll merge this back to the 2.0.0 branch if there are no objections.

Modified Paths:
--------------
    trunk/src/protocols/gg/gg.c
Modified: trunk/src/protocols/gg/gg.c
===================================================================
--- trunk/src/protocols/gg/gg.c	2006-07-27 02:20:33 UTC (rev 16582)
+++ trunk/src/protocols/gg/gg.c	2006-07-27 17:37:42 UTC (rev 16583)
@@ -1737,6 +1737,11 @@
 			gg_free_session(info->session);
 		}
 
+		/* Immediately close any notifications on this handle since that process depends
+		 * upon the contents of info->searches, which we are about to destroy.
+		 */
+		gaim_notify_close_with_handle(gc);
+
 		ggp_search_destroy(info->searches);
 		g_free(info);
 		gc->proto_data = NULL;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.