[Gaim-commits] SF.net SVN: gaim: [16271] trunk/src/protocols/msn

[<the...@us...>]

Revision: 16271
Author:   thekingant
Date:     2006-06-16 18:33:09 -0700 (Fri, 16 Jun 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16271&view=rev

Log Message:
-----------
Some comment changes

Modified Paths:
--------------
    trunk/src/protocols/msn/userlist.c
    trunk/src/protocols/oscar/oscar.c
    trunk/src/protocols/yahoo/yahoo_packet.c
Modified: trunk/src/protocols/msn/userlist.c
===================================================================
--- trunk/src/protocols/msn/userlist.c	2006-06-16 16:17:20 UTC (rev 16270)
+++ trunk/src/protocols/msn/userlist.c	2006-06-17 01:33:09 UTC (rev 16271)
@@ -292,6 +292,11 @@
  
 		if (!(user->list_op & (MSN_LIST_AL_OP | MSN_LIST_BL_OP)))
 		{
+			/*
+			 * TODO: The friendly name was NULL for me when I
+			 *       looked at this.  Maybe we should use the store
+			 *       name instead? --KingAnt
+			 */
 			got_new_entry(gc, passport, friendly);
 		}
 	}
@@ -413,7 +418,12 @@
 	if (list_op & MSN_LIST_RL_OP)
 	{
 		/* These are users who have us on their buddy list. */
-		/* TODO: what does store name is when this happens? */
+		/*
+		 * TODO: What is store name set to when this happens?
+		 *       For one of my accounts "som...@ho..."
+		 *       the store name was "something."  Maybe we
+		 *       should use the friendly name, instead? --KingAnt
+		 */
 
 		if (!(list_op & (MSN_LIST_AL_OP | MSN_LIST_BL_OP)))
 		{

Modified: trunk/src/protocols/oscar/oscar.c
===================================================================
--- trunk/src/protocols/oscar/oscar.c	2006-06-16 16:17:20 UTC (rev 16270)
+++ trunk/src/protocols/oscar/oscar.c	2006-06-17 01:33:09 UTC (rev 16271)
@@ -1903,6 +1903,7 @@
 			file = g_fopen(iconfile, "rb");
 			if (file) {
 				/* XXX - Use g_file_get_contents() */
+				/* g_file_get_contents(iconfile, &data, &len, NULL); */
 				int len = fread(buf, 1, st.st_size, file);
 				gaim_debug_info("oscar",
 						   "Sending buddy icon to %s (%d bytes, "

Modified: trunk/src/protocols/yahoo/yahoo_packet.c
===================================================================
--- trunk/src/protocols/yahoo/yahoo_packet.c	2006-06-16 16:17:20 UTC (rev 16270)
+++ trunk/src/protocols/yahoo/yahoo_packet.c	2006-06-17 01:33:09 UTC (rev 16271)
@@ -116,7 +116,7 @@
 
 		struct yahoo_pair *pair = g_new0(struct yahoo_pair, 1);
 
-		/* this is weird, and in one of the chat packets, and causes us
+		/* this is weird, and in one of the chat packets, and causes us to
 		 * think all the values are keys and all the keys are values after
 		 * this point if we don't handle it */
 		if (data[pos] == '\0') {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.