[Gaim-commits] SF.net SVN: gaim: [16070] trunk/plugins/log_reader.c

[<rl...@us...>]

Revision: 16070
Author:   rlaager
Date:     2006-04-19 22:12:22 -0700 (Wed, 19 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16070&view=rev

Log Message:
-----------
CID 104:
Function: trillian_logger_list
Description: Variable "data" tracked as NULL was dereferenced.

Yet another reminder that I need to work on this plugin again.

Modified Paths:
--------------
    trunk/plugins/log_reader.c
Modified: trunk/plugins/log_reader.c
===================================================================
--- trunk/plugins/log_reader.c	2006-04-20 04:58:29 UTC (rev 16069)
+++ trunk/plugins/log_reader.c	2006-04-20 05:12:22 UTC (rev 16070)
@@ -1131,17 +1131,17 @@
 
 			*c = '\0';
 			if (gaim_str_has_prefix(line, "Session Close ")) {
-				if (data && !data->length)
-					data->length = last_line_offset - data->offset;
-				if (!data->length) {
-					/* This log had no data, so we remove it. */
-					GList *last = g_list_last(list);
+				if (data && !data->length) {
+					if (!(data->length = last_line_offset - data->offset)) {
+						/* This log had no data, so we remove it. */
+						GList *last = g_list_last(list);
 
-					gaim_debug(GAIM_DEBUG_INFO, "Trillian log list",
-						"Empty log. Offset %i\n", data->offset);
+						gaim_debug(GAIM_DEBUG_INFO, "Trillian log list",
+							"Empty log. Offset %i\n", data->offset);
 
-					trillian_logger_finalize((GaimLog *)last->data);
-					list = g_list_delete_link(list, last);
+						trillian_logger_finalize((GaimLog *)last->data);
+						list = g_list_delete_link(list, last);
+					}
 				}
 			} else if (line[0] && line[1] && line [3] &&
 					   gaim_str_has_prefix(&line[3], "sion Start ")) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.