Re: [Gaim-i18n] Re: Search comment for Jabber is not translatable

[Richard L. <rl...@wi...>]

On Mon, 2006-04-10 at 22:44 +0200, Bjoern Voigt wrote:
> Richard Laager <rl...@wi...> wrote:
> 
> > We could take advantage of the fact that gettext doesn't honor #if 0...
> > 
> > #if 0
> > /* This is for gettext only. */
> > > static const char * jabber_user_dir_comments [] = {
> > > 	/* current comment from Jabber User Directory users.jabber.org */
> > > 	N_("Find a contact by entering the search criteria in the given fields. "
> > > 	   "Note: Each field supports wild card searches (%)"),
> > > 	NULL
> > > };
> > #endif
> 
> Ok. This is clever. 
> 
> I forget to write about another problem in the existing code:
> 
>   if((instnode = xmlnode_get_child(query, "instructions")))
>                 {
>                           char *tmp = xmlnode_get_data(instnode);
>                           instructions = g_strdup_printf(_("Server Instructions: %s"), tmp);
>                           g_free(tmp);
>                 }
> 
> What happens, if tmp is NULL?

Some systems will display "Server Instructions: (null)". Some systems
will crash. Yes, this should be checked.

Can you create a patch that addresses these concerns. If so, I'll apply
it unless someone objects.

Richard