From: Bjoern V. <bj...@cs...> - 2006-02-27 10:56:54
|
Richard Laager wrote: > Does the attached patch fix this? If so, I'll commit it. > =20 Unfortunately not. I tested the patch. There is still the English "I'dle = Mak'er" menu item. Since the string "I'dle Mak'er" is already translated = in some languages English users can test it with these languages (e.g.=20 "env LANG=3Dde_DE.utf8 gaim"). > I committed a fix. However, I didn't commit your extra space, as I don'= t see how that's useful... For me, there is nothing before the "Conversat= ion with..." line that the history plugin prints. > =20 Ok, the space was not good in this string. The problem only occurs if=20 both the history and the timestamp plugins are enabled. Please commit=20 the attached patch for the timestamp plugin. I tested all combinations=20 (no plugin, only timestamp plugin, only history plugin, both timestamp=20 and history plugin). In the case of "only timestamp plugin" there is an=20 extra space but you don't see it. It's interesting to see that the order = of the timestamp and "Conversation with..." strings depends on the load=20 order of the plugins. You can test this if you load and unload the=20 plugins in the plugin dialog. By the way: We discussed about time formats some time ago (Subject:=20 Translatable strftime() format strings?). I thought we agreed that it's=20 good to mark the time formats of strftime() with translation markers=20 "_()". Unfortunately we also found some problems with character set=20 conversations. After restarting Gaim there is a good order: 1) timestamp = from the timestamp plugin, 2) "Conversation with..." from the history=20 plugin. Why there are so much strftime() time format strings still not marked=20 with translation markers? Look at plugins/timestamp.c or=20 plugins/timestamp_format.c for instance. I think we are not consequent=20 here. But I'm also unsure, if we have enough time to test changes in=20 timestamp formats until 2.0.0 release. > > > * everything below "Debugging Information" in the Help->About windo= w. =20 > > > =20 > > Yes, but here I'm not sure if this is intended. If for instance a use= r=20 > > wants to copy this "Debugging Information" for a bug-report it's bett= er=20 > > to have this info in English. > > Yes, there is a comment in the source to that effect. We don't want tha= t > section translated. > =20 I agree. Greetings, Bj=C3=B6rn |