Re: [Gaim-devel] RC4 Cipher

[Gary K. <gr...@re...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sean Egan wrote:
> On 4/1/07, Nathan Peterson <gai...@gl...> wrote:
>> I implemented RC4 as a registered cipher in cipher.c.  It seems to work
>> great.  I will probably submit a patch soon after some more testing.
> 
> Awesome. I look forward to seeing it.
> 
>>  I have one question though.  Why is there a get_key_size operation defined
>> in the _GaimCipherOps struct?  None of the ciphers use it, and there is
>> no corresponding set_key_size operation.  I have decided to use the
>> set_option and get_option operations for setting and reading the key
>> size instead of messing with the get_key_size operation.  I believe this
>> is the correct thing to do, but I wanted to check first as to what the
>> intention of the get_key_size operation is.
> 
> Gary?

I see a set_key op right above get_key_size which iirc was meant that
for the cipher to determine.  Although that was a while ago, and I think
it was meant for encryption and since most, if not all, of our cipher
implementations are hashing algorithms, that'd make sense.  Aside from
that, no clue :)

- --
Gary Kramlich <gr...@re...>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGEYL4df4lmqisgDIRAoqAAJ4wCXYvcbZMfeVxapdWY/mm+/nEHgCgnS5l
W9bNnO1BT/RRkgHcajsQwHU=
=V+as
-----END PGP SIGNATURE-----