Re: [Gaim-devel] Error Messages for Duplicate Sign-on

[Richard L. <rl...@wi...>]

On Wed, 2006-10-25 at 12:36 -0400, Luke Schierer wrote:
> On Wed, Oct 25, 2006 at 11:30:23AM -0500, Richard Laager wrote:
> > Do we still want to be bringing up dialogs when you sign on from another
> > location? It seems like showing that as a connection error in the buddy
> > list (which we do) is sufficient. Otherwise we have duplication.

> I would say the blist is sufficient.

I found a minute to look into this. Apparently, we display the error
dialog when wants_to_die is TRUE. I think it's proper to show an error
message when the connection has some other sort of fatal error, I just
don't want a bunch of dialogs if I sign in elsewhere.

The easiest way I can think of to change this would be to make
wants_to_die and enum, where 0 is still FALSE, 1 is still TRUE, but 2 is
INVALID_PASSWORD. I'd have to make sure we're not actually comparing to
TRUE directly, but otherwise this shouldn't break anything. It feels a
little weird. I guess the alternative is to add a parameter to
gaim_connection_error() or another field in GaimConnection.

A bigger change would be to introduce behavior where the account
wouldn't be disabled, but wouldn't be reconnected either. This actually
seems ideal in this situation. That way, I don't have to re-enable all
my accounts.

Taking it further, if I was signed in at location A, then signed in at
location B, then went back to location A and changed my status, we could
have Gaim reconnect the accounts at that time.

Thoughts?

Thanks,
Richard