Menu
▾
▴
R: [Phrame-devel] Phrame and Log4php
|
From: Sergio S. <se...@as...> - 2003-10-02 16:56:04
|
Yes, "your" Phrame work well with Log4php 0.7 after replacing LoggerFactory::getLogger with LogFactory::getLog There is only one little modification of the define (in webapp), but nothing in phrame-lib I agree with you that there is no need to change everything, but several packages use pear Naming Conventions (ie. Phrame_ClassThis), so seem better to rename all functions before the next release. Why you say that the namespace problem will be solved by php5 ? I have not read anything about it ... I am working on two others things: - application configuration (with a web.xml file), used instead of modification of the WEB-INF/options.php file. - authentication & authorization (like jaas), to be integrated in HttpServletRequest: I am registering a new sf project for this. -----Messaggio originale----- Da: phr...@li... [mailto:phr...@li...]Per conto di Alex Inviato: giovedi 2 ottobre 2003 17.00 A: Jason Sweat; Sergio Strampelli; Phr...@li... Cc: vx...@us...; Alex Oggetto: Re: [Phrame-devel] Phrame and Log4php Hiya, The name Log4Php uses is LoggerManager::getLogger(). I've added an abstract factory to Phrame to be able to use different Loggers (or non at all, the supplied null-object) and called it LoggerFactory. No conflict in names there. But it is indeed different from Jakarta Commons. I've added my Log4Php code as add-on to my proposal code for the 2.1 release, so changing that should be easy enough. Seems pretty clear. The different controllers, however, are a bit more work. A search and replace should do the trick. Where are the php refactoring tools!? ;) Adding "Phrame" to every class cleans up the namespace, or rather sorts it, but calling every class PhrameClassThis and PhrameClassThat... Not sure about that. These issues with namespaces are something that'll automatically get sorted with php5. Though, obviously, that doesn't solve the problem now. I understand that Log4Php 0.7 works with the existing code, as is? I only tested it with a debugged 0.2. Kind regards, Alex --- Jason Sweat <jsw...@ya...> wrote: > Sounds like officially incorporating Alex's work and > renaming it to > PhrameLogFactory may be better all around to avoid > more future name conflicts. > > Jason > > > --- Sergio Strampelli <se...@as...> wrote: > > Hello! > > > > I am working on a project using both Phrame (by > Alex) and Log4php (versione > > 0.7), but I discovered a conflict in the name of > the class LoggerFactory. > > > > Looking at the original packages, LoggerFactory is > the name used in Log4j > > and LogFactory is the class used in Struts > > (org.apache.commons.logging.LogFactory). > > > > So, I think that Phrame should use LogFactory > instead of LoggerFactory to > > avoid conflict. > > > > P.S.: The method of LogFactory is getLog, not > getLogger > > > > Let me know. > > > > Sergio > > > > > > > > > > > > > ------------------------------------------------------- > > This sf.net email is sponsored by:ThinkGeek > > Welcome to geek heaven. > > http://thinkgeek.com/sf > > _______________________________________________ > > Phrame-devel mailing list > > Phr...@li... > > > https://lists.sourceforge.net/lists/listinfo/phrame-devel > > > __________________________________ > Do you Yahoo!? > The New Yahoo! Shopping - with improved product > search > http://shopping.yahoo.com > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Phrame-devel mailing list > Phr...@li... > https://lists.sourceforge.net/lists/listinfo/phrame-devel __________________________________ Do you Yahoo!? The New Yahoo! Shopping - with improved product search http://shopping.yahoo.com ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Phrame-devel mailing list Phr...@li... https://lists.sourceforge.net/lists/listinfo/phrame-devel |
