Re: [Phrame-devel] What about Phrame's internals?

[Alex <ale...@ya...>]

Hiya Pieter,

> (1) Why isn't HttpSession just be a wrapper around
> $_SESSION? This would also provide compatibility
> with 
> components utilizing $_SESSION directly.

Well, it sort of is. It *is* a wrapper around
$_SESSION. I've placed an extra HashMap
on the $_SESSION to keep Phrame session
attributes apart from other session usage. 

For example, if you call $session->invalidate() 
it only clears Phrame's session attributes
(the session state) all other usage of 
$_SESSION remain perfectly untouched. 
It limits side-effects somewhat.

You could easily change that behaviour
for future versions, if you'd want. You
have a good point about compatibility.

> (2) Why isn't HttpServletRequest->_requestState just
> a
> wrapper around $_REQUEST? As far as I can see,
> putting
> values in _requestState will not be reflected in
> $_REQUEST, which could cause problems for components
> utilizing $_REQUEST directly.

I've split up the request attributes (request
state) and request parameters ($_REQUEST) over 
what you looked at. The parameters part could 
indeed quite easily directly access $_REQUEST.
The request attributes should not be put
on $_REQUEST. They are to be mapped to the 
templates and should be kept seperated.

Kind regards,

Alex



__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com