[Phrame-devel] ActionController.php - part 2

[Jason S. <jsw...@ya...>]

These changes are a bit more extensive, but I do not believe they have any
backwards compatability issues.  

The first change is to allow for the _possible_ definition of the PHP constant
DISABLE_PHRAME_ERROR_HANDLING.  If this constant is defined, and it is not set
to false, then this will _NOT_ set the custom error handling.  This is very
useful for debugging, as the error handler will generally hide PHP fatal errors
when enabled.

The second change is to pass by reference where objects are expected (and
return by reference as well).

The third change is the exit; after header(); mentioned in the prior post.

Jason

$ diff ActionController.php ActionController.jes.php
110c110,111
<               error_reporting($this->_options[_ERROR_REPORTING]);
---
>               if(!defined('DISABLE_PHRAME_ERROR_HANDLING') ||
DISABLE_PHRAME_ERROR_
HANDLING === false)
>                       error_reporting($this->_options[_ERROR_REPORTING]);
134c135
<       function _processMapping($mappings, $request)
---
>       function &_processMapping($mappings, $request)
155c156
<       function _processForm($mappings, $request)
---
>       function &_processForm($mappings, $request)
165a167,169
>                                       require_once "forms/$type.php";
>                               }
>                               if (!class_exists($type)) {
189c193
<       function _processValidate($actionMapping, $actionForm)
---
>       function _processValidate(&$actionMapping, &$actionForm)
192c196,197
<               set_error_handler($this->_options[_ERROR_HANDLER]);
---
>               if(!defined('DISABLE_PHRAME_ERROR_HANDLING') ||
DISABLE_PHRAME_ERROR_
HANDLING === false)
>                       set_error_handler($this->_options[_ERROR_HANDLER]);
199c204,205
<               restore_error_handler();
---
>               if(!defined('DISABLE_PHRAME_ERROR_HANDLING') ||
DISABLE_PHRAME_ERROR_
HANDLING === false)
>                       restore_error_handler();
210c216
<       function _processAction($actionMapping, $actionForm)
---
>       function &_processAction(&$actionMapping, &$actionForm)
216a223,225
>                               require_once "actions/$type.php";
>                       }
>                       if (!class_exists($type)) {
236c245
<       function _processForward($actionForward)
---
>       function _processForward(&$actionForward)
241a251
>                       exit;
245a256
>                       exit;

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com