[phpXML] Some comments

[<an...@is...>]

I've sent these comments to Michael shortly after downloading phpXML
class, but have not received a reply, so I'm going to repost them here.

1. It would be nice to provide XML content to the class as a string
instead of just in a file.

2. "'" => "&apos" in $entities is missing a semicolon.

3. I don't know why you really need to perform strtr() call in
handle_character_data() - it converts ' to ' for example - what's
the point?

4. You are running trim() on $text in handle_character_data() - why?
This has unfortunate side effect of removing spaces that might have
wanted to keep there, especially when handle_character_data() is called
multiple times on the #PCDATA block because it has & entities inside..

-Andrei
* I don't have a solution but I admire the problem. *

--
This message has been sent through the <phpXML/> user discussion list. To unsubscribe, please visit https://sslsites.de/mailinglisten/user/us...@li.../